Skip to content

Remove outdated TODO from TopDocsAndMaxScore #126386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025
Merged

Remove outdated TODO from TopDocsAndMaxScore #126386

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79b2d7f
Remove outdated TODO from TopDocsAndMaxScore
javanna Apr 7, 2025
d886bbb
Merge branch 'main' into non-issue/remove_max_score_todo
javanna Apr 7, 2025
9bcbdfe
Merge branch 'main' into non-issue/remove_max_score_todo
javanna Apr 7, 2025
5bd0fef
Merge branch 'main' into non-issue/remove_max_score_todo
javanna Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions server/src/main/java/org/elasticsearch/common/lucene/search/TopDocsAndMaxScore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
/**
* Wrapper around a {@link TopDocs} instance and the maximum score.
*/
// TODO: Remove this class when https://github.com/elastic/elasticsearch/issues/32981 is addressed.
public final class TopDocsAndMaxScore {

public final TopDocs topDocs;
Expand All @@ -24,5 +23,4 @@ public TopDocsAndMaxScore(TopDocs topDocs, float maxScore) {
this.topDocs = topDocs;
this.maxScore = maxScore;
}

}