[main] System data streams are not being upgraded in the feature migration API #126409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation API This commit adds support for system data streams reindexing. The system data stream migration extends the existing system indices migration task and uses the data stream reindex API. The system index migration task starts a reindex data stream task and tracks its status every second. Only one system index or system data stream is migrated at a time. If a data stream migration fails, the entire system index migration task will also fail. Port of elastic#123926
alexey-ivanov-es
added
>bug
:Core/Infra/Core
…le migrated prefix (elastic#125598) There is a theoretical possibility of having an index backing a system data stream with a name starting with .migrated-migrated-. This currently results in an error when accessing the data stream. This commit fixes the issue.
JVerwolf
approved these changes
Apr 8, 2025
Contributor
JVerwolf
left a comment
JVerwolf
left a comment
There was a problem hiding this comment.
LGTM. A few minor comments, not blocking.
docs/changelog/124884.yaml
Outdated
| @@ -0,0 +1,6 @@ | |||
| pr: 124884 | |||
Contributor
There was a problem hiding this comment.
Should this reference the current PR?
| () -> format( | ||
| "resuming system index migration with index [%s], which does not match index given in last task state [%s]", | ||
| nextMigrationInfo.getCurrentIndexName(), | ||
| "resuming system index migration with resource [%s]," |
Contributor
There was a problem hiding this comment.
Nit: system index -> system resource?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for system data streams reindexing. The system data stream migration extends the existing system indices migration task and uses the data stream reindex API.
The system index migration task starts a reindex data stream task and tracks its status every second. Only one system index or system data stream is migrated at a time. If a data stream migration fails, the entire system index migration task will also fail.
Port of #123926
This PR also includes port of #125598