Skip to content

Conversation

@smalyshev
Copy link
Contributor

@smalyshev smalyshev commented Apr 7, 2025

  • Initialize clusters earlier
  • Simplify cluster set calculation
  • No need to keep separate skipped list for enrich resolution

This helps clean up the code in preparation for enabling remote lookup indices (needed for LOOKUP JOIN).

- Initialize clusters earlier
- Simplify cluster set calculation
- No need to keep separate skipped list for enrich resolution
@smalyshev smalyshev added :Analytics/ES|QL AKA ESQL >refactoring v8.19.0 auto-backport Automatically create backport pull requests when merged labels Apr 7, 2025
@smalyshev smalyshev force-pushed the refactor-esql-clusters branch from 7a350a8 to 23bd44c Compare April 7, 2025 23:07
@smalyshev smalyshev force-pushed the refactor-esql-clusters branch from 23bd44c to 89c781c Compare April 7, 2025 23:09
@smalyshev smalyshev requested a review from quux00 April 7, 2025 23:20
@smalyshev smalyshev marked this pull request as ready for review April 8, 2025 15:07
@smalyshev smalyshev requested a review from dnhatn April 8, 2025 15:07
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@smalyshev smalyshev requested a review from astefan April 8, 2025 15:08
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@quux00 quux00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smalyshev smalyshev merged commit b21e325 into elastic:main Apr 8, 2025
18 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 126426

@smalyshev
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Apr 8, 2025
* Refactor remote cluster handling in Analyzer

- Initialize clusters earlier
- Simplify cluster set calculation
- No need to keep separate skipped list for enrich resolution

(cherry picked from commit b21e325)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java
elasticsearchmachine pushed a commit that referenced this pull request Apr 8, 2025
* Refactor remote cluster handling in Analyzer

- Initialize clusters earlier
- Simplify cluster set calculation
- No need to keep separate skipped list for enrich resolution

(cherry picked from commit b21e325)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants