Support maxConnections override in AbstractBlobContainerRetriesTestCase tests #126435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiannaHohensee
added
>test
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
approved these changes
Apr 8, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM. This method's parameters are getting a little out of hand :)
Contributor
|
I'm going to backport this to |
DaveCTurner
pushed a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 8, 2025
The mostly-optional parameters to `createBlobContainer` are getting rather numerous in this test harness which makes the tests hard to read. This commit introduces a builder to help name the provided parameters and skip the omitted ones. It also adds a `maxConnections` override. Backport of elastic#126445 and elastic#126435 to `8.x` Co-authored-by: Dianna Hohensee <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 8, 2025
The mostly-optional parameters to `createBlobContainer` are getting rather numerous in this test harness which makes the tests hard to read. This commit introduces a builder to help name the provided parameters and skip the omitted ones. It also adds a `maxConnections` override. Backport of #126445 and #126435 to `8.x` Co-authored-by: Dianna Hohensee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committing some boilerplate changes to support a maxConnections http client test -- see feature branch commit (#testMaxConnections()).