Skip to content

ESQL: Updated RENAME docs with the behaviour of multiple column renames #126462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

ESQL: Updated RENAME docs with the behaviour of multiple column renames #126462

merged 2 commits into from
Apr 9, 2025

Conversation

@ivancea
Copy link
Contributor

@ivancea ivancea commented Apr 8, 2025

Update RENAME documentation after #122250

@ivancea ivancea added >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v8.19.0 v9.0.1 v9.1.0 labels Apr 8, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Apr 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

craigtaverner
craigtaverner requested changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new example to the rename.csv-spec file so it can be included in the commands docs once that automation is re-enabled (hopefully soon).

docs/reference/query-languages/esql/esql-commands.md
With multiple `RENAME` commands:

```esql
FROM employees
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the same as the version in docs.csv-spec:104

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be automating the inclusion of examples soon, so my PR will fix this, making it the same as the example in the csv-spec. If you prefer this two-line RENAME, then edit the example in the csv-spec

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, I see now, this is the third example, and it does not exist at all in rename.csv-spec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the example

craigtaverner
craigtaverner approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivancea ivancea merged commit 90dcccf into elastic:main Apr 9, 2025
16 checks passed
@ivancea ivancea deleted the esql-rename-updated-docs branch April 9, 2025 10:39
@ivancea ivancea mentioned this pull request Apr 9, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts
✅ 9.0

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 126462

ivancea added a commit to ivancea/elasticsearch that referenced this pull request Apr 9, 2025
@ivancea
ESQL: Updated RENAME docs with the behaviour of multiple column renam…
30182ae 
…es (elastic#126462)

* ESQL: Updated RENAME docs with the behaviour of multiple column renames

* Added rename example to csv-spec
@ivancea ivancea mentioned this pull request Apr 9, 2025
Merged
elasticsearchmachine pushed a commit that referenced this pull request Apr 9, 2025
@ivancea
ESQL: Updated RENAME docs with the behaviour of multiple column renam…
6c8ac6e 
…es (#126462) (#126522)

* ESQL: Updated RENAME docs with the behaviour of multiple column renames

* Added rename example to csv-spec
ivancea added a commit that referenced this pull request Apr 10, 2025
@ivancea
[8.x] ESQL: Updated RENAME docs with the behaviour of multiple column…
3ff010b 
… renames (#126523)

Manual backport of #126462

As docs changed in 9.x, it had to be manually backported to the old asciidoc format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craigtaverner craigtaverner craigtaverner approved these changes

@alex-spies alex-spies alex-spies approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ivancea @elasticsearchmachine @craigtaverner @alex-spies