Add max_over_time aggregation for TSDB #126498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
max_over_time
branch
2 times, most recently
from
3ae9557 to
8951ed4
Compare
dnhatn
added
>non-issue
:StorageEngine/TSDB
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
reviewed
Apr 9, 2025
| QUERY_MONITORING; | ||
| QUERY_MONITORING, | ||
|
|
||
| MAX_OVER_TIME(Build.current().isSnapshot()); |
Contributor
There was a problem hiding this comment.
Nit: add explanatory comment as the rest of the entries.
kkrik-es
reviewed
Apr 9, 2025
| * | STATS sum(`rate(request)`), `min(memory_used)` = from_partial($p1, min($)) BY pod=`VALUES(pod)`, `bucket(@timestamp, 5m)` | ||
| * | KEEP `min(memory_used)`, `sum(rate(request))`, pod, `bucket(@timestamp, 5m)` | ||
| * | ||
| * _over_time time-series aggregation will be rewritten in the similar way |
kkrik-es
reviewed
Apr 9, 2025
| * becomes | ||
| * | ||
| * TS k8s | ||
| * | STATS max(memory_usage), VALUES(host) BY _tsid, bucket(@timestamp, 1minute) |
Contributor
There was a problem hiding this comment.
Maybe: | STATS max_memory_usage=max(memory_usage), VALUES(host) BY _tsid, bucket(@timestamp, 1minute)
to reference it below?
kkrik-es
approved these changes
Apr 9, 2025
Contributor
kkrik-es
left a comment
kkrik-es
left a comment
There was a problem hiding this comment.
Awesome, it's really nice to see this getting generalized so easily. We can add the rest with minimal effort, too.
martijnvg
approved these changes
Apr 9, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Thanks Nhat, this approach looks very clean 👍
Member
Author
|
@kkrik-es @martijnvg Thanks :) |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the
max_over_timeaggregation for time_series indices. Similar to therateaggregation, this aggregation is translated into two stages: the first stage groups by_tsid(and time-bucket), and the second stage groups by the user-specified groups.For example:
is translated into:
In this case, we don't need to keep the Lucene source emitted in the order of _tsid/timestamp, but I leave this optimization for the future.
Other
*_over_timefunctions will be added later.