Semantic Text Rolling Upgrade Tests #126548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikep86
added
>test
Mikep86
commented
Apr 9, 2025
x-pack/qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/SemanticTextUpgradeIT.java
Show resolved
Hide resolved
kderusso
reviewed
Apr 9, 2025
x-pack/qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/SemanticTextUpgradeIT.java
Show resolved
Hide resolved
x-pack/qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/SemanticTextUpgradeIT.java
Outdated
Show resolved
Hide resolved
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
kderusso
approved these changes
May 1, 2025
Samiul-TheSoccerFan
approved these changes
May 1, 2025
x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/model/TestModel.java
Show resolved
Hide resolved
|
The 8.19 tests are failing because the semantic text chunking config transport version needs to be ported to |
|
@elasticmachine update branch |
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
May 6, 2025
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 7, 2025
* Semantic Text Rolling Upgrade Tests (#126548) * Fix test failures --------- Co-authored-by: Elastic Machine <[email protected]>
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
May 7, 2025
(cherry picked from commit 2eb9fab) # Conflicts: # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/model/TestModel.java
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
May 7, 2025
…127748) * Semantic Text Rolling Upgrade Tests (elastic#126548) * Fix test failures --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit a3a64ea) # Conflicts: # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/model/TestModel.java
Mikep86
added a commit
to Mikep86/elasticsearch
that referenced
this pull request
May 7, 2025
…127748) * Semantic Text Rolling Upgrade Tests (elastic#126548) * Fix test failures --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit a3a64ea) # Conflicts: # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/model/TestModel.java
Mikep86
added a commit
that referenced
this pull request
May 8, 2025
Mikep86
added a commit
that referenced
this pull request
May 8, 2025
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a rolling upgrade test suite for basic
semantic_textfunctionality. Covers indexing docs, querying, and highlighting.I chose to go with an integration test approach because we cannot perform inference via the Inference API in this context (it depends on a mock inference services plugin that we cannot load). Instead, we depend on passing in pre-computed inference results at index and query time. It's much easier to do this in an integration test where we can: