ESQL: Fix bug in octal ip parsing tests #126552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in the tests for parsing ipv4 addresses with leading zeros as octal numbers. The bug was in the expectation code that we use for random input ips. Closes elastic#126496
nik9000
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
This was referenced Apr 9, 2025
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 9, 2025
This fixes a bug in the tests for parsing ipv4 addresses with leading zeros as octal numbers. The bug was in the expectation code that we use for random input ips. Closes elastic#126496
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 9, 2025
This fixes a bug in the tests for parsing ipv4 addresses with leading zeros as octal numbers. The bug was in the expectation code that we use for random input ips. Closes elastic#126496
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 10, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the tests for parsing ipv4 addresses with leading zeros as octal numbers. The bug was in the expectation code that we use for random input ips.
Closes #126496