Remove unnecessary request from log tests #126556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchaplin
added
>test
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
Were you able to repro the failures locally? I tried but I could not. |
javanna
approved these changes
Apr 11, 2025
|
No, I couldn't either. |
💔 Backport failed
You can use sqren/backport to manually backport by running |
benchaplin
added a commit
to benchaplin/elasticsearch
that referenced
this pull request
Apr 11, 2025
(cherry picked from commit c11b8f1) # Conflicts: # muted-tests.yml
benchaplin
added a commit
to benchaplin/elasticsearch
that referenced
this pull request
Apr 11, 2025
(cherry picked from commit c11b8f1) # Conflicts: # muted-tests.yml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
benchaplin
added a commit
to benchaplin/elasticsearch
that referenced
this pull request
Apr 11, 2025
(cherry picked from commit c11b8f1) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 11, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 11, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #126358 & #126357.
This final request is unnecessary - by the nature of the above while loop, the async search will complete before the assertion. My theory is that this final request causes shard locks to remain held in a busy cluster after the assertion has succeeded, explaining the intermittent failures.
Also, this line is one of the only meaningful differences between these tests and others in the class, which have not been failing :).