Fix missing index handling #126564
Closed
Fix missing index handling #126564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalyshev
added
auto-backport
smalyshev
force-pushed
the
fix-missing-index-handling
branch
from
374df05 to
c1ecafa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with missing indices being ignored (see #126275).
I am not in love with this because it looks like a hack, and proper fix would be to move handling of this into verifier, but the way field caps works now it doesn't seem possible without protocol changes, which won't work with older clusters.
Also, it doesn't fix the case of
which now seems to be broken regardless of partials being enabled (see #114495)