[Failure store] Support failure store for system data streams #126585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>non-issue
:Core/Infra/Core
elasticsearchmachine
added
Team:Core/Infra
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
alexey-ivanov-es
approved these changes
Apr 10, 2025
Contributor
alexey-ivanov-es
left a comment
alexey-ivanov-es
left a comment
There was a problem hiding this comment.
I've left a small comment, overall LGTM
| } | ||
|
|
||
| List<Index> failureIndices = dataStream.getFailureIndices(); | ||
| assertThat(failureIndices, hasSize(failureIndices.size())); |
Contributor
There was a problem hiding this comment.
This assertion always passes, did you mean something else?
Contributor
Author
There was a problem hiding this comment.
:face_palm: yes I will fix it. Thank you for pointing it out
gmarouli
added
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
Apr 10, 2025
…c#126585) In this PR we add support for the failure store for system data streams. Specifically: - We pass the system descriptor so the failure index can be created based on that. - We extend the tests to ensure it works - We remove a guard we had but I wasn't able to test it because it only gets triggered if the data stream gets created right after a failure in the ingest pipeline, and I didn't see how to add one (yet). - We extend the system data stream migration to ensure this is also working. (cherry picked from commit 78ac5d5) # Conflicts: # x-pack/plugin/security/src/internalClusterTest/java/org/elasticsearch/integration/DataStreamLifecycleServiceRuntimeSecurityIT.java
gmarouli
added a commit
that referenced
this pull request
Apr 11, 2025
… (#126639) In this PR we add support for the failure store for system data streams. Specifically: - We pass the system descriptor so the failure index can be created based on that. - We extend the tests to ensure it works - We remove a guard we had but I wasn't able to test it because it only gets triggered if the data stream gets created right after a failure in the ingest pipeline, and I didn't see how to add one (yet). - We extend the system data stream migration to ensure this is also working. (cherry picked from commit 78ac5d5) # Conflicts: # x-pack/plugin/security/src/internalClusterTest/java/org/elasticsearch/integration/DataStreamLifecycleServiceRuntimeSecurityIT.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add support for the failure store for system data streams. Specifically: