Only create the writer for the cache when needed #126592
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating the writer to the cache of newly downloaded data can be quite involved (requires quite a few objects to be created underneath). However, this writer is only really used if we have things to download from the object store. This proposes we delay creating the writer until it's actually needed, such that the fast path of `maybeFetch...`ing something avoids creating the entire machinery of `SequentialRangeMissingHandler` and the needed `BlobCacheReader`.
andreidan
added
>non-issue
:Search Foundations/Search
elasticsearchmachine
added
the
serverless-linked
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Contributor
Author
|
Closing as we'll make use of a lazy range writer to wrap the supplier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the writer to the cache of newly downloaded data can be quite involved (requires quite a few objects to be created underneath). However, this writer is only really used if we have things to download from the object store.
This proposes we delay creating the writer until it's actually needed, such that the fast path of
maybeFetch...ing something avoids creating the entire machinery ofSequentialRangeMissingHandlerand the neededBlobCacheReaderwhen the cache is already warm.NB: with online prewarming we expect the cache for hot indices to be warm way more than cold (i.e. we warm each segment once and then, on every incoming search request targeting the warmed indices the
maybeFetch...calls will be no-ops)