Skip to content

Conversation

@nik9000
Copy link
Member

@nik9000 nik9000 commented Apr 10, 2025

Adds a simple script to run benchmarks for ESQL and collect their results. The script has a --test mode which takes about ten minutes. Running without --test takes a four hours fifteen minutes.

To speed up --test I reworked the "self test" that each benchmark runs to be optional and disabled in --test mode.

Adds a simple script to run benchmarks for ESQL and collect their
results. The script has a `--test` mode which takes about ten minutes.
Running without `--test` takes a four hours fifteen minutes.

To speed up `--test` I reworked the "self test" that each benchmark runs
to be optional and disabled in `--test` mode.
@nik9000 nik9000 requested a review from idegtiarenko April 10, 2025 11:54
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

valuesBigArray,
totalPositions,
null,
IntStream.rangeClosed(0, totalPositions).toArray(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were required to run the self-test with assertions enabled. Which we do when we run them in tests.

case TWO_LONGS -> List.of(ElementType.INT, ElementType.INT);
case LONGS_AND_BYTES_REFS -> List.of(ElementType.INT, ElementType.BYTES_REF);
case TWO_LONGS -> List.of(ElementType.LONG, ElementType.LONG);
case LONGS_AND_BYTES_REFS -> List.of(ElementType.LONG, ElementType.BYTES_REF);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were just mistakes.

Page page = page(data);
for (int i = 0; i < 1024; i++) {
operator.addInput(page);
operator.addInput(page.shallowCopy());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake.

@nik9000
Copy link
Member Author

nik9000 commented Apr 10, 2025

@nik9000 nik9000 enabled auto-merge (squash) April 18, 2025 16:05
@nik9000 nik9000 merged commit 85749d6 into elastic:main Apr 18, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants