[Test] Fix testGenerateMultipleCertificateWithNewCA #126621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an edge case where we randomly generate an empty list of key usages then pass it to `certutil` command. The empty means just apply the defaults, but we assert based on the generated empty set. Resolves elastic#126471
slobodanadamovic
added
>test
|
Pinging @elastic/es-security (Team:Security) |
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Apr 11, 2025
Fixes an edge case where we randomly generate an empty list of key usages then pass it to `certutil` command. The empty means just apply the defaults, but we assert based on the generated empty set. Resolves elastic#126471 Co-authored-by: Tim Vernum <[email protected]> (cherry picked from commit 3db258e) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 11, 2025
Fixes an edge case where we randomly generate an empty list of key usages then pass it to `certutil` command. The empty means just apply the defaults, but we assert based on the generated empty set. Resolves #126471 Co-authored-by: Tim Vernum <[email protected]> (cherry picked from commit 3db258e) # Conflicts: # muted-tests.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge test case where we randomly generate an empty list of key
usages then pass it to
certutilcommand. The empty means just applythe defaults, but we end up asserting based on the generated empty set.
Resolves #126471