Add docker hub specific docker context #126625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
commented
Apr 10, 2025
| $VERSION_QUALIFIER_ARG \ | ||
| buildReleaseArtifacts \ | ||
| exportCompressedDockerImages \ | ||
| exportDockerContexts \ |
There was a problem hiding this comment.
we implicitly build those contexts as part of building the images. Since they are deliverables, we want to build them explicitly. Also, we now build the docker hub specific context but not a corresponding image for that
jozala
requested changes
Apr 11, 2025
jozala
approved these changes
Apr 11, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Apr 11, 2025
The labels we require for openshift are incompatible with docker hub policies. therefore we need to use different docker contexts for those. (cherry picked from commit 31995ac)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a specific docker context that we use for docker hub. For now this only removes specific docker labels that should not be used in docker hub.