Dry up o.e.c.lucene.Lucene transport logic #126646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've accumulated quited a bit of duplication here, drying this logic up a little.
original-brownbear
added
>non-issue
:Search Foundations/Search
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
Team:Search Foundations
drempapis
approved these changes
Apr 11, 2025
Contributor
drempapis
left a comment
drempapis
left a comment
There was a problem hiding this comment.
LGTM! Maintenance work is important from time to time
original-brownbear
added
auto-backport
Contributor
Author
|
Thanks Dimitris! |
Collaborator
💚 Backport successful
|
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Apr 11, 2025
We've accumulated quited a bit of duplication here, drying this logic up a little.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've accumulated quited a bit of duplication here, drying this logic up a little.