Release buffers in netty test #126744
Merged
Release buffers in netty test #126744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhl-b
added
>test
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
approved these changes
Apr 14, 2025
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM with optional suggestions
Comment on lines
143
to
146
| var lastContent = channel.readInbound(); | ||
| assertTrue(lastContent instanceof LastHttpContent); | ||
| ((LastHttpContent) lastContent).release(); | ||
|
|
Contributor
There was a problem hiding this comment.
Or, in one line (with slightly nicer failure message too):
Suggested change
| var lastContent = channel.readInbound(); | |
| assertTrue(lastContent instanceof LastHttpContent); | |
| ((LastHttpContent) lastContent).release(); | |
| asInstanceOf(LastHttpContent.class, channel.readInbound()).release(); |
Comment on lines
165
to
167
| var fullReq = channel.readInbound(); | ||
| assertTrue(fullReq instanceof FullHttpRequest); | ||
| ((FullHttpRequest) fullReq).release(); |
Contributor
There was a problem hiding this comment.
Likewise
Suggested change
| var fullReq = channel.readInbound(); | |
| assertTrue(fullReq instanceof FullHttpRequest); | |
| ((FullHttpRequest) fullReq).release(); | |
| asInstanceOf(FullHttpRequest.class, channel.readInbound()).release(); |
brianseeders
added a commit
to brianseeders/elasticsearch
that referenced
this pull request
Apr 17, 2025
This reverts commit f9f3def.
bcully
added a commit
to bcully/elasticsearch
that referenced
this pull request
Apr 17, 2025
This reverts commit f9f3def.
bcully
pushed a commit
that referenced
this pull request
Apr 17, 2025
ankikuma
added a commit
to ankikuma/elasticsearch
that referenced
this pull request
Apr 17, 2025
This reverts commit f9f3def. Revert Netty4HttpHeaderValidatorTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release leaking buffers in Netty4HttpHeaderValidatorTests.
Closes #126743
Closes #126745
Closes #126749