RepositoryAnalysisFailureIT: fix testFailsOnWriteException #126750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the addition of copy coverage in the repository analyzer, blob count is no longer 1:1 with blob analyzer request count: requests that create a copy count as two blobs. This can cause testFailsOnWriteException to sometimes fail, because this test randomly injects a failure somewhere between the first and blobCounth request, which may never happen if enough of the requests create copies. This simple fix is to inject the failure within blobCount/2 requests, which we will see even if every request generates a copy. An alternative could be to add a knob to the request to disallow copies and use that during this test. Closes elastic#126747
bcully
added
>test
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
Contributor
Author
|
I'll wait for main to get #126779 and repush, with luck that'll clear up the bwc-snapshots failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of copy coverage in the repository analyzer, blob count is no longer 1:1 with blob analyzer request count: requests that create a copy count as two blobs. This can cause testFailsOnWriteException to sometimes fail, because this test randomly injects a failure somewhere between the first and blobCounth request, which may never happen if enough of the requests create copies.
This simple fix is to inject the failure within blobCount/2 requests, which we will see even if every request generates a copy. An alternative could be to add a knob to the request to disallow copies and use that during this test.
Closes #126747