Skip to content

[8.x] Return float[] instead of List<Double> in valueFetcher (#126702) #126811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

[8.x] Return float[] instead of List<Double> in valueFetcher (#126702) #126811

merged 1 commit into from
Apr 15, 2025

Conversation

@iverase
Copy link
Contributor

@iverase iverase commented Apr 15, 2025

Backports the following commits to 8.x:

@iverase
Return float[] instead of List<Double> in valueFetcher (elastic#126702)
234c81d 
We are currently having to hold in heap big list of Double objects which can take big amounts of heap. With this change 
we can reduce the heap usage by 7x.
@iverase iverase added :Search Relevance/Search Catch all for Search Relevance >enhancement auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Apr 15, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Apr 15, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit 1ec12b1 into elastic:8.x Apr 15, 2025
15 checks passed
@iverase iverase deleted the backport/8.x/pr-126702 branch April 15, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >enhancement :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iverase @elasticsearchmachine