Skip to content

Fix formatting of recently added transport versions using old format #126826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

Fix formatting of recently added transport versions using old format #126826

merged 2 commits into from
Apr 15, 2025

Conversation

@mosche
Copy link
Contributor

@mosche mosche commented Apr 15, 2025

The format of Transport versions has changed to M_NNN_S_PP a while ago to allow for more patch versions on recent long lived branches. Some recent PRs have switched formatting back to the old formatting. That's dangerous as it might trick devs into creating wrong TVs for serverless. Please be careful!

M - The major version of Elasticsearch
NNN - The server version part
S - The subsidiary version part. It should always be 0 here, it is only used in subsidiary repositories.
PP - The patch version part

@mosche mosche added >non-issue :Core/Infra/Core Core issues without another label labels Apr 15, 2025
@mosche mosche requested review from a team, bcully, kderusso, nik9000 and prwhelan April 15, 2025 09:21
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team v9.1.0 labels Apr 15, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Apr 15, 2025

Pinging @elastic/es-core-infra (Team:Core/Infra)

ldematte
ldematte approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosche mosche merged commit ed7d72a into elastic:main Apr 15, 2025
17 checks passed
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request Apr 16, 2025
@mosche @afoucret
Fix formatting of recently added transport versions using old format (e…
9453172 
…lastic#126826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldematte ldematte ldematte approved these changes

@bcully bcully Awaiting requested review from bcully

@nik9000 nik9000 Awaiting requested review from nik9000

@prwhelan prwhelan Awaiting requested review from prwhelan

@kderusso kderusso Awaiting requested review from kderusso

Assignees

No one assigned

Labels

:Core/Infra/Core Core issues without another label >non-issue Team:Core/Infra Meta label for core/infra team v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mosche @elasticsearchmachine @ldematte