Remove needless array indirection in AbstractInternalTerms #126830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obviously just a single count, make it a plain field like the counter next to it.
original-brownbear
added
>non-issue
:Analytics/Aggregations
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
iverase
reviewed
Apr 15, 2025
| getRequiredSize(), | ||
| getOrder(), | ||
| removed -> otherDocCount[0] += removed.getDocCount(), | ||
| removed -> otherDocCount += removed.getDocCount(), |
Contributor
There was a problem hiding this comment.
I thought you cannot use mutable variables like that in lambda functions.
Contributor
Author
There was a problem hiding this comment.
You can if they are a field on an object, just not mutable locals :)
iverase
approved these changes
Apr 15, 2025
idegtiarenko
approved these changes
Apr 15, 2025
original-brownbear
added
the
auto-backport
Contributor
Author
|
Thanks you two! |
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 15, 2025
afoucret
pushed a commit
to afoucret/elasticsearch
that referenced
this pull request
Apr 16, 2025
…26830) Obviously just a single count, make it a plain field like the counter next to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Randomly found small win :)
Obviously just a single count, make it a plain field like the counter next to it.