Skip to content

Fix IndexStatsIT#testFilterCacheStats #126844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix IndexStatsIT#testFilterCacheStats #126844

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cebd35
Fix `IndexStatsIT#testFilterCacheStats`
arteam Apr 15, 2025
52fa628
Merge branch 'main' into fix-index-stats-it-persist-global-checkpoint
arteam Apr 15, 2025
d08495b
Merge branch 'main' into fix-index-stats-it-persist-global-checkpoint
elasticmachine Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions server/src/internalClusterTest/java/org/elasticsearch/indices/stats/IndexStatsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
import org.elasticsearch.test.ESIntegTestCase.ClusterScope;
import org.elasticsearch.test.ESIntegTestCase.Scope;
import org.elasticsearch.test.InternalSettingsPlugin;
import org.elasticsearch.test.junit.annotations.TestLogging;
import org.elasticsearch.xcontent.XContentType;

import java.io.IOException;
Expand Down Expand Up @@ -1095,7 +1094,6 @@ private void assertCumulativeQueryCacheStats(IndicesStatsResponse response) {
assertEquals(total, shardTotal);
}

@TestLogging(value = "org.elasticsearch.cluster.service:TRACE", reason = "https://github.com/elastic/elasticsearch/issues/124447")
public void testFilterCacheStats() throws Exception {
Settings settings = Settings.builder()
.put(indexSettings())
Expand Down Expand Up @@ -1370,10 +1368,12 @@ private void persistGlobalCheckpoint(String index) throws Exception {
for (IndexService indexService : indexServices) {
for (IndexShard indexShard : indexService) {
indexShard.sync();
assertThat(
"Routing entry for shard " + indexShard.routingEntry().toString(),
indexShard.getLastSyncedGlobalCheckpoint(),
equalTo(indexShard.getLastKnownGlobalCheckpoint())
assertBusy(
() -> assertThat(
"Routing entry for shard " + indexShard.routingEntry().toString(),
indexShard.getLastSyncedGlobalCheckpoint(),
equalTo(indexShard.getLastKnownGlobalCheckpoint())
)
);
}
}
Expand Down