Use DelayableWriteable with batched query execution #126864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should use DelayableWriteable here as well just like we do with per-shard results. The heap savings of making use of this tool are quite significant at times and without using it we could actually regress in terms of heap use relative to non-batched execution in corner cases of a low but larger than one number of shards per node.
original-brownbear
added
>non-issue
:Search Foundations/Search
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
elasticsearchmachine
added
the
Team:Search Foundations
| ); | ||
| try { | ||
| Iterator<InternalAggregations> aggsIter = Iterators.map(toConsume, r -> { | ||
| try (var res = r.consumeAggs()) { |
Contributor
Author
There was a problem hiding this comment.
This made me realize and fixes a small mistake on the left hand side as well. We don't need to retain the buffer after a call to expand(), not sure why I thought that before 🤦♂️ ... so we can save a bit of heap on average here by releasing before forwarding to the reducer.
javanna
approved these changes
Apr 16, 2025
Member
|
Change is good, I do think that we need unit tests for QueryPhaseResultConsumer. Not the first time this need comes up. |
Contributor
Author
|
Thanks Luca! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use DelayableWriteable here as well just like we do with per-shard results. The heap savings of making use of this tool are quite significant at times and without using it we could actually regress in terms of heap use relative to non-batched execution in corner cases of a low but larger than one number of shards per node (because the serialized representation can be considerably smaller than the materialized one, outweighing the gains from partial reduction in some cases).