Skip to content

GCS: Use idempotency token to identify requests when present #126887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

GCS: Use idempotency token to identify requests when present #126887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...t/java/org/elasticsearch/repositories/gcs/GoogleCloudStorageBlobStoreRepositoryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,8 @@ private static class GoogleCloudStorageBlobStoreHttpHandler extends GoogleCloudS
@SuppressForbidden(reason = "this test uses a HttpServer to emulate a Google Cloud Storage endpoint")
private static class GoogleErroneousHttpHandler extends ErroneousHttpHandler {

private static final String IDEMPOTENCY_TOKEN = "x-goog-gcs-idempotency-token";

GoogleErroneousHttpHandler(final HttpHandler delegate, final int maxErrorsPerRequest) {
super(delegate, maxErrorsPerRequest);
}
Expand All @@ -340,6 +342,10 @@ protected String requestUniqueId(HttpExchange exchange) {
}
}

if (exchange.getRequestHeaders().containsKey(IDEMPOTENCY_TOKEN)) {
return exchange.getRequestHeaders().getFirst(IDEMPOTENCY_TOKEN);
}

final String range = exchange.getRequestHeaders().getFirst("Content-Range");
return exchange.getRemoteAddress().getHostString()
+ " "
Expand Down