Collapse transport versions #127186
Merged
Collapse transport versions #127186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdoyle
added
:Core/Infra/Transport API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
This test had been using the version INITIAL_ELASTICSEARCH_9_0 as an example of a version that used the older ByteSizeValue transport format. Now that no such version exists anymore, it doesn't make sense to substitute a version that uses the new format!
prdoyle
force-pushed
the
collapse-tv
branch
2 times, most recently
from
b443a8a to
fe8fb25
Compare
|
Bah, messed up my branch and put it back. |
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 5, 2025
This reverts commit 76c2ab5.
jdconrad
added a commit
that referenced
this pull request
Sep 8, 2025
jdconrad
added a commit
to jdconrad/elasticsearch
that referenced
this pull request
Sep 8, 2025
This reverts commit 76c2ab5.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I drove my work based on
TransportVersions.csv:INITIAL_ELASTICSEARCHentry for a version in the CSV, rename it toV_.V_9_0_0and use it for all9xxxversions up to and including the value from the CSV, which was9_000_0_09I did not notice any obvious dead code using
V_9_0_0.I did not try to differentiate between 8.17.6 and 8.18.0.