- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
ESQL: Disable a bugged commit #127199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            ESQL: Disable a bugged commit #127199
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    The PR elastic#126641 has a bug with `!=`.
| 
           Pinging @elastic/es-analytical-engine (Team:Analytics)  | 
    
| 
           Hi @nik9000, I've created a changelog YAML for you.  | 
    
              
                    dnhatn
  
              
              approved these changes
              
                  
                    Apr 22, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
              
                    idegtiarenko
  
              
              approved these changes
              
                  
                    Apr 23, 2025 
                  
              
              
            
            
| 
           It looks like one of the tests is failing sometimes. i'm going to squash and merge this anyway to get the disable and let the robot mute the test.  | 
    
    
  nik9000 
      added a commit
        to nik9000/elasticsearch
      that referenced
      this pull request
    
      Apr 23, 2025 
    
    
      
  
    
      
    
  
Had to sort. Relates to elastic#127199
    
  nik9000 
      added a commit
      that referenced
      this pull request
    
      Apr 23, 2025 
    
    
      
  
    
      
    
  
Had to sort. Relates to #127199
    
  nik9000 
      added a commit
        to nik9000/elasticsearch
      that referenced
      this pull request
    
      May 19, 2025 
    
    
      
  
    
      
    
  
The PR elastic#126641 has a bug with `!=`.
    
  nik9000 
      added a commit
        to nik9000/elasticsearch
      that referenced
      this pull request
    
      May 19, 2025 
    
    
      
  
    
      
    
  
Had to sort. Relates to elastic#127199
| 
           Backported by #128156  | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    :Analytics/ES|QL
  AKA ESQL 
  
    auto-merge-without-approval
  Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) 
  
    >bug
  
    Team:Analytics
  Meta label for analytical engine team (ESQL/Aggs/Geo) 
  
    v9.1.0
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
The PR #126641 has a bug with
!=.Closes #127197