Skip to content

Conversation

@thecoop
Copy link
Member

@thecoop thecoop commented Apr 23, 2025

Fixes #127162

@thecoop thecoop added >bug :Search Relevance/Ranking Scoring, rescoring, rank evaluation. labels Apr 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've created a changelog YAML for you.

@thecoop thecoop marked this pull request as ready for review April 23, 2025 13:41
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Apr 23, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@benwtrent benwtrent requested a review from javanna April 23, 2025 16:35
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thecoop this looks good to me and makes sense.

I requested a review from @javanna as he might have thoughts on this part of the code.

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop thecoop merged commit 83300ea into elastic:main Apr 29, 2025
17 checks passed
@thecoop thecoop deleted the field-score-missing-field branch April 29, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Search Relevance/Ranking Scoring, rescoring, rank evaluation. Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FieldValueFactorFunction should return bad_request when fields are missing

4 participants