Speedup resolving index aliases in TransportSearchAction (and in general) #127231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of dead code accumulated here cleaning it up.
…ral) Very often there are no aliases, no need to create a bunch of objects in this case. Also, no need to build an intermediary candidate list either. Plus the nested streams do get very costly when running this logic over a large number of indices.
original-brownbear
added
>non-issue
:Data Management/Indices APIs
Contributor
Author
|
This gets very short once #127227 is merged |
elasticsearchmachine
added
v9.1.0
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
Author
|
Thanks Chris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very often there are no aliases, no need to create a bunch of objects in this case.
Also, no need to build an intermediary candidate list either.
Plus the nested streams do get very costly when running this logic over a large number
of indices.