Replace auto-read with proper flow-control in HTTP pipeline #127259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-applying elastic#126441 with the extra `FlowControlHandler` needed to ensure one-chunk-per-read semantics - see elastic#127111 for related tests.
DaveCTurner
added
>enhancement
:Distributed Coordination/Network
DaveCTurner
changed the title
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
commented
Apr 24, 2025
Comment on lines
+432
to
+435
| // See https://github.com/netty/netty/issues/15053: the combination of FlowControlHandler and HttpContentDecompressor above | ||
| // can emit multiple chunks per read, but HttpBody.Stream requires chunks to arrive one-at-a-time so until that issue is | ||
| // resolved we must add another flow controller here: | ||
| ch.pipeline().addLast(new FlowControlHandler()); |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 25, 2025
…lastic#127259)" This reverts commit 3cf7061 and unmutes the associated tests Closes elastic#127391 Closes elastic#127392
DaveCTurner
added a commit
that referenced
this pull request
Apr 25, 2025
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 7, 2025
Re-applying elastic#126441 (cf. elastic#127259) with: - the extra `FlowControlHandler` needed to ensure one-chunk-per-read semantics (also present in elastic#127259). - no extra `read()` after exhausting a `Netty4HttpRequestBodyStream` (the bug behind elastic#127391 and elastic#127391). See elastic#127111 for related tests.
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
…127817) Re-applying elastic#126441 (cf. elastic#127259) with: - the extra `FlowControlHandler` needed to ensure one-chunk-per-read semantics (also present in elastic#127259). - no extra `read()` after exhausting a `Netty4HttpRequestBodyStream` (the bug behind elastic#127391 and elastic#127391). See elastic#127111 for related tests.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
…127817) Re-applying elastic#126441 (cf. elastic#127259) with: - the extra `FlowControlHandler` needed to ensure one-chunk-per-read semantics (also present in elastic#127259). - no extra `read()` after exhausting a `Netty4HttpRequestBodyStream` (the bug behind elastic#127391 and elastic#127391). See elastic#127111 for related tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-applying #126441 with the extra
FlowControlHandlerneeded to ensureone-chunk-per-read semantics - see #127111 for related tests.