Skip to content

[8.x] Skip region validation in S3BlobStoreRepositoryTests (#127372) #127381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

[8.x] Skip region validation in S3BlobStoreRepositoryTests (#127372) #127381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ee1e23
Skip region validation in `S3BlobStoreRepositoryTests` (#127372)
DaveCTurner Apr 25, 2025
d2a210c
Merge branch '8.19' into backport/8.x/pr-127372
nicktindall Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...nternalClusterTest/java/org/elasticsearch/repositories/s3/S3BlobStoreRepositoryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,9 @@ public void handle(final HttpExchange exchange) throws IOException {
assertTrue(
isValidAwsV4SignedAuthorizationHeader(
"test_access_key",
Objects.requireNonNullElse(region, "us-east-1"),
// If unset, the region used by the SDK is usually going to be `us-east-1` but sometimes these tests run on bare EC2
// machines and the SDK picks up the region from the IMDS there, so for now we use '*' to skip validation.
Objects.requireNonNullElse(region, "*"),
"s3",
exchange.getRequestHeaders().getFirst("Authorization")
)
Expand Down