-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Adding transport actions for getting and updating data stream settings #127417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
masseyke
merged 3 commits into
elastic:main
from
masseyke:data-stream-settings-transport-action
Apr 28, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
355 changes: 355 additions & 0 deletions
355
...eams/src/internalClusterTest/java/org/elasticsearch/datastreams/DataStreamSettingsIT.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
.../main/java/org/elasticsearch/datastreams/action/TransportGetDataStreamSettingsAction.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the "Elastic License | ||
| * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
| * Public License v 1"; you may not use this file except in compliance with, at | ||
| * your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
| * License v3.0 only", or the "Server Side Public License, v 1". | ||
| */ | ||
|
|
||
| package org.elasticsearch.datastreams.action; | ||
|
|
||
| import org.elasticsearch.action.ActionListener; | ||
| import org.elasticsearch.action.admin.indices.settings.get.GetSettingsAction; | ||
| import org.elasticsearch.action.datastreams.GetDataStreamSettingsAction; | ||
| import org.elasticsearch.action.support.ActionFilters; | ||
| import org.elasticsearch.action.support.IndicesOptions; | ||
| import org.elasticsearch.action.support.local.TransportLocalProjectMetadataAction; | ||
| import org.elasticsearch.cluster.ProjectState; | ||
| import org.elasticsearch.cluster.block.ClusterBlockException; | ||
| import org.elasticsearch.cluster.block.ClusterBlockLevel; | ||
| import org.elasticsearch.cluster.metadata.DataStream; | ||
| import org.elasticsearch.cluster.metadata.IndexNameExpressionResolver; | ||
| import org.elasticsearch.cluster.project.ProjectResolver; | ||
| import org.elasticsearch.cluster.service.ClusterService; | ||
| import org.elasticsearch.common.settings.Settings; | ||
| import org.elasticsearch.common.settings.SettingsFilter; | ||
| import org.elasticsearch.injection.guice.Inject; | ||
| import org.elasticsearch.tasks.Task; | ||
| import org.elasticsearch.threadpool.ThreadPool; | ||
| import org.elasticsearch.transport.TransportService; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class TransportGetDataStreamSettingsAction extends TransportLocalProjectMetadataAction< | ||
| GetDataStreamSettingsAction.Request, | ||
| GetDataStreamSettingsAction.Response> { | ||
| private final IndexNameExpressionResolver indexNameExpressionResolver; | ||
| private final SettingsFilter settingsFilter; | ||
|
|
||
| @Inject | ||
| public TransportGetDataStreamSettingsAction( | ||
| TransportService transportService, | ||
| ClusterService clusterService, | ||
| ThreadPool threadPool, | ||
| SettingsFilter settingsFilter, | ||
| ActionFilters actionFilters, | ||
| ProjectResolver projectResolver, | ||
| IndexNameExpressionResolver indexNameExpressionResolver | ||
| ) { | ||
| super( | ||
| GetSettingsAction.NAME, | ||
| actionFilters, | ||
| transportService.getTaskManager(), | ||
| clusterService, | ||
| threadPool.executor(ThreadPool.Names.MANAGEMENT), | ||
| projectResolver | ||
| ); | ||
| this.indexNameExpressionResolver = indexNameExpressionResolver; | ||
| this.settingsFilter = settingsFilter; | ||
| } | ||
|
|
||
| @Override | ||
| protected ClusterBlockException checkBlock(GetDataStreamSettingsAction.Request request, ProjectState state) { | ||
| return state.blocks().globalBlockedException(ClusterBlockLevel.METADATA_WRITE); | ||
| } | ||
|
|
||
| @Override | ||
| protected void localClusterStateOperation( | ||
| Task task, | ||
| GetDataStreamSettingsAction.Request request, | ||
| ProjectState project, | ||
| ActionListener<GetDataStreamSettingsAction.Response> listener | ||
| ) throws Exception { | ||
| List<String> dataStreamNames = indexNameExpressionResolver.dataStreamNames( | ||
| clusterService.state(), | ||
| IndicesOptions.DEFAULT, | ||
| request.indices() | ||
| ); | ||
| Map<String, DataStream> dataStreamMap = project.metadata().dataStreams(); | ||
| List<GetDataStreamSettingsAction.DataStreamSettingsResponse> responseList = new ArrayList<>(dataStreamNames.size()); | ||
| for (String dataStreamName : dataStreamNames) { | ||
| DataStream dataStream = dataStreamMap.get(dataStreamName); | ||
| Settings settings = settingsFilter.filter(dataStream.getSettings()); | ||
| Settings effectiveSettings = settingsFilter.filter(dataStream.getEffectiveSettings(project.metadata())); | ||
| responseList.add(new GetDataStreamSettingsAction.DataStreamSettingsResponse(dataStreamName, settings, effectiveSettings)); | ||
| } | ||
| listener.onResponse(new GetDataStreamSettingsAction.Response(responseList)); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ for using the local action, thanks!