-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add info to date processor docs
#127434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PeteGillinElastic
merged 7 commits into
elastic:main
from
PeteGillinElastic:date-processor-docs
Apr 29, 2025
Merged
Add info to date processor docs
#127434
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4c930ca
Add info to `date` processor docs
PeteGillinElastic a1502b4
Add info to `date` processor docs
PeteGillinElastic ad72e36
Add section headers and cross-references per review suggestion
PeteGillinElastic bc95b03
Merge remote-tracking branch 'upstream/main' into date-processor-docs
PeteGillinElastic ff35345
Tweak wording as suggested
PeteGillinElastic eb98827
Tweak the order of a couple of subclauses to make it more readable
PeteGillinElastic f93d9db
Merge remote-tracking branch 'upstream/main' into date-processor-docs
PeteGillinElastic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: If you gave this section a heading you could link to it from the table instead of writing
(see below)Looking at the URL preview, there are no subheadings at all on this page which makes it hard to scan :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's a good idea. I've just added a bunch of section headings, and turned both the
belows into links. (I previewed the docs locally and the cross-references work as expected, so hopefully I got the format right.)I've still left it saying 'see below', because I needed something as an anchor text. If there's a preference for a different style, please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Made a suggestion to incorporate link into the text more naturally :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yeah, that's better. Done. (I somehow mashed the wrong button in github and failed to apply your suggestion, but I've pushed a commit with the exact same change!)