Skip to content

Conversation

@mmahacek
Copy link
Contributor

@mmahacek mmahacek requested a review from Copilot April 28, 2025 21:05
@mmahacek mmahacek self-assigned this Apr 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Elasticsearch documentation to explain the default JVM heap sizing calculations based on the node's role.

  • Adds a new section on default JVM heap sizes.
  • Provides distinct sizing guidelines for Master-only, Machine Learning-only, and Data-only nodes.

@elasticsearchmachine
Copy link
Collaborator

@mmahacek please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added v9.1.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 28, 2025
@PeteGillinElastic PeteGillinElastic added >docs General docs changes :Core/Infra/Core Core issues without another label and removed needs:triage Requires assignment of a team area label labels May 1, 2025
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team labels May 1, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/core-docs (Team:Docs)

@rjernst
Copy link
Member

rjernst commented Aug 23, 2025

I'm not sure we want to document these exact percentages/numbers. There's no way to keep them in sync, and the logic is already complex. The point of auto heap sizing is that the user doesn't need to worry about determining how much heap they need, so it's unclear to me what benefit documenting this brings, they shouldn't have to think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/Core Core issues without another label >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v8.18.9 v8.19.0 v9.0.9 v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants