Increase blob container max register content length #127491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
ywangd
approved these changes
Apr 30, 2025
Member
ywangd
left a comment
ywangd
left a comment
There was a problem hiding this comment.
LGTM
I am not aware any hard requirement on the maximum register size. I think it is intended to be small and 24 bytes are still pretty small imo.
pxsalehi
added a commit
that referenced
this pull request
May 5, 2025
Allowing a bit more space than #127491, for the same purposes. Relates ES-11205
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
Allowing a bit more space than elastic#127491, for the same purposes. Relates ES-11205
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
Allowing a bit more space than elastic#127491, for the same purposes. Relates ES-11205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two more (stateless) use cases related that requires a bit more space. For project lease files, we'd need just 16B to store the cluster UUID and another 8B for two ints. Also for soft-deletions we will extend the cluster state lease to have one more counter for project deletions.
Relates ES-11205