ESQL: Remove temporary workarounds for resolved bugs

[kanoshiou]

As far as I have tested, #127167 appears to be a variant of #126026, and #125870 seems to be a variant of #126392. Since these issues have been resolved, the temporary workaround can now be safely removed.

Closes #127167
Closes #125870

[elasticsearchmachine]

Pinging @elastic/es-analytical-engine (Team:Analytics)

[luigidellaquila]

buildkite test this

[luigidellaquila]

Thanks @kanoshiou!
I see some failures in the CI that seem completely unrelated to the changes introduced by this PR.
I'm updating the branch to see if they get fixed

[luigidellaquila]

buildkite test this

[kanoshiou]

Thank you @luigidellaquila !

I noticed a failed test in the last CI run related to this PR.

./gradlew ":x-pack:plugin:esql:qa:server:multi-clusters:v9.1.0#newToOld" -Dtests.class="org.elasticsearch.xpack.esql.ccq.MultiClusterSpecIT" -Dtests.method="test {eval.EvalAfterGroupingUsingSameName5}" -Dtests.seed=BB2926D5EC19AEEC -Dtests.bwc=true -Dtests.locale=ln-Latn-CD -Dtests.timezone=Indian/Kerguelen -Druntime.java=24

MultiClusterSpecIT > test {eval.EvalAfterGroupingUsingSameName5} FAILED
    org.elasticsearch.client.ResponseException: method [POST], host [http://[::1]:62902], URI [/_query?pretty=true&error_trace=true], status line [HTTP/1.1 400 Bad Request]
    ---
    error:
      root_cause:
      - type: "parsing_exception"
        reason: "line 7:15: invalid index pattern [*:firewall_logs,firewall_logs,*:threat_list,threat_list,*:airports,airports],\
          \ remote clusters are not supported in LOOKUP JOIN"
        stack_trace: "org.elasticsearch.xpack.esql.parser.ParsingException: line 7:15:\
          \ invalid index pattern [*:firewall_logs,firewall_logs,*:threat_list,threat_list,*:airports,airports],\
          \ remote clusters are not supported in LOOKUP JOIN\n\tat org.elasticsearch.xpack.esql.parser.LogicalPlanBuilder.lambda$visitJoinCommand$24(LogicalPlanBuilder.java:621)\n\

I’m not sure how to resolve it, so any guidance would be greatly appreciated!

[luigidellaquila]

Thanks for checking.
Adding required_capability: join_lookup_v12 should solve the problem

[kanoshiou]

Thanks, @luigidellaquila! I've updated the branch.

[luigidellaquila]

buildkite test this

[luigidellaquila]

The CI is not happy about the changelog file apparently.
The error is not clear, but my guess is that it could be the type: test.
In this case I think we don't need a changelog entry at all actually

[kanoshiou]

[$.type: does not have a value in the enumeration [breaking, breaking-java, bug, deprecation, enhancement, feature, known-issue, new-aggregation, regression, security, upgrade]]

I noticed that you added the test label, so I updated the type to test😂.
Should I change the type value or just delete the changelog?

[luigidellaquila]

I'd just remove the delete the file

[kanoshiou]

I have removed the changelog.

[luigidellaquila]

buildkite test this

[luigidellaquila]

Thanks @kanoshiou! LGTM