Skip to content

ESQL: No, line noise isn't a valid ip #127527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

ESQL: No, line noise isn't a valid ip #127527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06489af
ESQL: No, line noise isn't a valid ip
nik9000 Apr 29, 2025
d871526
Update docs/changelog/127527.yaml
nik9000 Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/127527.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 127527
summary: "No, line noise isn't a valid ip"
area: ES|QL
type: bug
issues: []
4 changes: 2 additions & 2 deletions ...rc/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/convert/ParseIp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,14 +212,14 @@ public static BytesRef leadingZerosAreOctal(
}

private static int digit(BytesRef string, int offset) {
if (string.bytes[offset] < '0' && '9' < string.bytes[offset]) {
if (string.bytes[offset] < '0' || '9' < string.bytes[offset]) {
throw invalid(string);
}
return string.bytes[offset] - '0';
}

private static int octalDigit(BytesRef string, int offset) {
if (string.bytes[offset] < '0' && '7' < string.bytes[offset]) {
if (string.bytes[offset] < '0' || '7' < string.bytes[offset]) {
throw invalid(string);
}
return string.bytes[offset] - '0';
Expand Down
17 changes: 17 additions & 0 deletions ...st/java/org/elasticsearch/xpack/esql/expression/function/scalar/convert/ParseIpTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,23 @@ public static Iterable<Object[]> parameters() {
new TestCase("255.0", false, false, false),
new TestCase("255.255.1", false, false, false),
new TestCase("255.255.0", false, false, false),
new TestCase("a.a.a.a", false, false, false),
new TestCase(
/*
* At some point the ip parsing code parsed this as a valid ipv4 address. Use git-blame if you
* are curious. It was a dark time.
*/
"\u0007I\u001B|R\u0017t)Q W+\u001F5\n"
+ "(\u001E~H@u9Sbc~2\u000BH=\tNZ_vSUnv/GL=5Ag2n\u0012 P\u0007?dyA,=~F!\u001C0\fQ\u0011\u0012.5<yR <I;rU\u001A"
+ "\u001Av4(\u0014q{\u0018\u001FE\u000B1T8N\\\u0015\u000F\n"
+ "N3T(\n"
+ "\u000B,\u0017)_r\u007F*1\u0018`T\"0%hlvBsOkKeb+.b6\u001Bz5\"U\u000Fe\u0019).\u0003XArg\u001E\fWxbF\u0001\u0015"
+ "%(JQ_]\u001Aw'#vD\tW\u0016w)mNx&\u001E\u001B\u0007\u000FPf5Hw\u0004\u0015\u0015\\\u007FG\"~XJ\u0006"
+ "aE\u0018}Y9\u001C\u0018a",
false,
false,
false
),
new TestCase(new Supplier<>() {
@Override
public String get() {
Expand Down
Loading