Fix bug in EsqlDataTypeConverterTests #127529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limotova
added
>test
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
There was a bug when trying to generate a Set using Set.of when a randomly picked DataType is already present in one of the other arguments, causing an IllegalArgumentException to be thrown
limotova
force-pushed
the
suggested-cast-test-bug
branch
from
44be17d to
16a9cd7
Compare
…ests testSuggestedCast elastic#127535" This reverts commit 7b3f43f.
dnhatn
approved these changes
Apr 30, 2025
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
There are two test methods, randomValueOtherThan and randomValueOtherThanMany, for this. But the fix in this PR looks good already - no need to change. Thanks Larisa for fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when trying to generate a Set using Set.of when a
randomly picked DataType is already present in one of the other
arguments, causing an IllegalArgumentException to be thrown
Fixes #127514, #127535