ES|QL: fix generative tests #127560
ES|QL: fix generative tests #127560
Conversation
luigidellaquila
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
luigidellaquila
changed the title
luigidellaquila
changed the title
| private static String randomName(List<Column> previousOutput) { | ||
| String result = randomRawName(previousOutput); | ||
| if (result.isEmpty() // bug https://github.com/elastic/elasticsearch/issues/125870, we'll manage it as an error later | ||
| || result.contains("<") |
There was a problem hiding this comment.
Have you considered excluding <no-fields> from randomRawName instead?
And maybe create a static variable that excludes these two and be called in multiple places in this class; I see randomGroupableName and randomRawName excludes <all-fields-projected>.
There was a problem hiding this comment.
Actually, <all-fields-projected> is found in 8 places in this file...
There was a problem hiding this comment.
That's a good point.
From a purely functional point of view, <no-fields> is there and you can use it, so having it in the tests would make sense.
On the other hand, quoting all the <something> fields would probably make the test less effective in discovering other bugs.
I think I'll go with your suggestion and just add <no-fields> to a blacklist
There was a problem hiding this comment.
Oh... I just tested it with
from no_* | limit 1 | keep `<no-fields>`
Unknown column [<no-fields>], did you mean [<no-fields>]?
There was a problem hiding this comment.
I did some refactoring, now the management of special cases for field names is centralized.
3 participants
Refactoring of how field names are extracted from the output of the previous query, taking into consideration known issues.
Fixes: #127536