Remove unneeded special IOContext for cache prewarming #127575
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
| recoveryState.getIndex().addFileDetail(file.physicalName(), file.length(), false); | ||
| try { | ||
| final IndexInput input = openInput(file.physicalName(), CachedBlobContainerIndexInput.CACHE_WARMING_CONTEXT); | ||
| final IndexInput input = openInput(file.physicalName(), IOContext.DEFAULT); |
Contributor
There was a problem hiding this comment.
It looks like this would be a behavior change? IOContext.DEFAULT uses DEFAULT_READADVICE which will use ReadAdvice.RANDOM unless the system property org.apache.lucene.store.defaultReadAdvice is set. The CachedBlobContainerIndexInput.CACHE_WARMING_CONTEXT instance was being created using ReadAdvice.NORMAL explicitly.
Member
Author
There was a problem hiding this comment.
Doh, yes of course it is. Nevermind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This IOContext did use to do something, but does no longer. So just remove it.