Skip to content

[8.19] Mark semantic text inference_id param as optional #127587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

[8.19] Mark semantic text inference_id param as optional #127587

merged 1 commit into from
May 1, 2025

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Apr 30, 2025

No description provided.

@Mikep86 Mikep86 added >docs General docs changes auto-backport Automatically create backport pull requests when merged :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v8.18.1 v8.19.0 v8.17.7 labels Apr 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@Mikep86 Mikep86 mentioned this pull request Apr 30, 2025
Merged
@seanhandley
Copy link

I'm lacking some context here @Mikep86 (I'm 3 days old at Elastic) but can you explain about why this change is necessary, or link to some resources with more context? It's unclear to me whether:

  • It was a mistake to mark this parameter as Required
  • Something has changed to allow us to default to some other inference service behind the scenes, allowing the parameter to be softened to Optional
  • Maybe something else?

@seanhandley
Copy link

Ignore previous comment, I see we're defaulting to elser now 👍

@Mikep86 Mikep86 merged commit f2765c3 into elastic:8.19 May 1, 2025
6 checks passed
This was referenced May 1, 2025
Merged
Merged
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request May 1, 2025
@Mikep86
Mark semantic text inference_id param as optional (elastic#127587)
9f87fbd
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.18
✅ 8.17

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request May 1, 2025
@Mikep86
Mark semantic text inference_id param as optional (elastic#127587)
1101029
elasticsearchmachine pushed a commit that referenced this pull request May 1, 2025
@Mikep86
Mark semantic text inference_id param as optional (#127587) (#127602)
67bd512
elasticsearchmachine pushed a commit that referenced this pull request May 1, 2025
@Mikep86
Mark semantic text inference_id param as optional (#127587) (#127603)
64628f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ioanatia ioanatia ioanatia approved these changes

@kderusso kderusso Awaiting requested review from kderusso

@Samiul-TheSoccerFan Samiul-TheSoccerFan Awaiting requested review from Samiul-TheSoccerFan

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v8.17.7 v8.18.1 v8.19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mikep86 @elasticsearchmachine @seanhandley @ioanatia