Skip to content

Conversation

@DaveCTurner
Copy link
Contributor

Provide a little more justification for why we do not always fork to the
provided executor since it's a little counterintuitive at first sight.

Provide a little more justification for why we do not always fork to the
provided `executor` since it's a little counterintuitive at first sight.
@DaveCTurner DaveCTurner requested a review from pxsalehi May 6, 2025 10:14
@DaveCTurner DaveCTurner added >non-issue v8.19.0 v9.1.0 :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. labels May 6, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label May 6, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

Copy link
Member

@pxsalehi pxsalehi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@DaveCTurner DaveCTurner added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged labels May 6, 2025
@elasticsearchmachine elasticsearchmachine merged commit cc536db into elastic:main May 7, 2025
17 checks passed
@DaveCTurner DaveCTurner deleted the 2025/05/06/SubscribableListener-executor-docs branch May 7, 2025 22:14
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 7, 2025
…#127746)

Provide a little more justification for why we do not always fork to the
provided `executor` since it's a little counterintuitive at first sight.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19

elasticsearchmachine pushed a commit that referenced this pull request May 7, 2025
#127870)

Provide a little more justification for why we do not always fork to the
provided `executor` since it's a little counterintuitive at first sight.
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request May 9, 2025
…#127746)

Provide a little more justification for why we do not always fork to the
provided `executor` since it's a little counterintuitive at first sight.
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request May 12, 2025
…#127746)

Provide a little more justification for why we do not always fork to the
provided `executor` since it's a little counterintuitive at first sight.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. >non-issue Team:Distributed Coordination Meta label for Distributed Coordination team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants