Change the handling of passthrough dimenensions #127752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We collect helper methods to an base test case so all tests can benefit.
gmarouli
added
>bug
:StorageEngine/Downsampling
|
Hi @gmarouli, I've created a changelog YAML for you. |
gmarouli
changed the title
gmarouli
commented
May 7, 2025
...rTest/java/org/elasticsearch/xpack/downsample/DataStreamLifecycleDownsampleDisruptionIT.java
Show resolved
Hide resolved
gmarouli
added
auto-backport
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
approved these changes
May 7, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
May 8, 2025
When downsampling an index that has a mapping with passthrough dimensions the downsampling process identifies the wrapper object as a dimension and it fails when it tried to retrieve the type. We did some prework to establish a shared framework in the internalClusterTest. For now it only includes setting up time series data stream helpers and a limited assertion helper for dimensions and metrics. This allows us to setup an internalClusterTest that captures this issue during downsampling in elastic#125156. To fix this we refine the check that determines if a field is dimension, to skip wrapper field. Fixes elastic#125156.
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
May 8, 2025
When downsampling an index that has a mapping with passthrough dimensions the downsampling process identifies the wrapper object as a dimension and it fails when it tried to retrieve the type. We did some prework to establish a shared framework in the internalClusterTest. For now it only includes setting up time series data stream helpers and a limited assertion helper for dimensions and metrics. This allows us to setup an internalClusterTest that captures this issue during downsampling in elastic#125156. To fix this we refine the check that determines if a field is dimension, to skip wrapper field. Fixes elastic#125156.
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
May 8, 2025
When downsampling an index that has a mapping with passthrough dimensions the downsampling process identifies the wrapper object as a dimension and it fails when it tried to retrieve the type. We did some prework to establish a shared framework in the internalClusterTest. For now it only includes setting up time series data stream helpers and a limited assertion helper for dimensions and metrics. This allows us to setup an internalClusterTest that captures this issue during downsampling in elastic#125156. To fix this we refine the check that determines if a field is dimension, to skip wrapper field. Fixes elastic#125156.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
…7886) * Change the handling of passthrough dimenensions (#127752) When downsampling an index that has a mapping with passthrough dimensions the downsampling process identifies the wrapper object as a dimension and it fails when it tried to retrieve the type. We did some prework to establish a shared framework in the internalClusterTest. For now it only includes setting up time series data stream helpers and a limited assertion helper for dimensions and metrics. This allows us to setup an internalClusterTest that captures this issue during downsampling in #125156. To fix this we refine the check that determines if a field is dimension, to skip wrapper field. Fixes #125156. * Fix backport incompatibilities
gmarouli
added a commit
that referenced
this pull request
May 8, 2025
When downsampling an index that has a mapping with passthrough dimensions the downsampling process identifies the wrapper object as a dimension and it fails when it tried to retrieve the type. We did some prework to establish a shared framework in the internalClusterTest. For now it only includes setting up time series data stream helpers and a limited assertion helper for dimensions and metrics. This allows us to setup an internalClusterTest that captures this issue during downsampling in #125156. To fix this we refine the check that determines if a field is dimension, to skip wrapper field. Fixes #125156.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
When downsampling an index that has a mapping with passthrough dimensions the downsampling process identifies the wrapper object as a dimension and it fails when it tried to retrieve the type. We did some prework to establish a shared framework in the internalClusterTest. For now it only includes setting up time series data stream helpers and a limited assertion helper for dimensions and metrics. This allows us to setup an internalClusterTest that captures this issue during downsampling in #125156. To fix this we refine the check that determines if a field is dimension, to skip wrapper field. Fixes #125156.
gmarouli
added a commit
to gmarouli/elasticsearch
that referenced
this pull request
May 8, 2025
…stic#127890) When downsampling an index that has a mapping with passthrough dimensions the downsampling process identifies the wrapper object as a dimension and it fails when it tried to retrieve the type. We did some prework to establish a shared framework in the internalClusterTest. For now it only includes setting up time series data stream helpers and a limited assertion helper for dimensions and metrics. This allows us to setup an internalClusterTest that captures this issue during downsampling in elastic#125156. To fix this we refine the check that determines if a field is dimension, to skip wrapper field. Fixes elastic#125156.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 8, 2025
…7890) (#127905) * Change the handling of passthrough dimenensions (#127752) (#127890) When downsampling an index that has a mapping with passthrough dimensions the downsampling process identifies the wrapper object as a dimension and it fails when it tried to retrieve the type. We did some prework to establish a shared framework in the internalClusterTest. For now it only includes setting up time series data stream helpers and a limited assertion helper for dimensions and metrics. This allows us to setup an internalClusterTest that captures this issue during downsampling in #125156. To fix this we refine the check that determines if a field is dimension, to skip wrapper field. Fixes #125156. * Adjust the test to match this version of the code
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
When downsampling an index that has a mapping with passthrough dimensions the downsampling process identifies the wrapper object as a dimension and it fails when it tried to retrieve the type. We did some prework to establish a shared framework in the internalClusterTest. For now it only includes setting up time series data stream helpers and a limited assertion helper for dimensions and metrics. This allows us to setup an internalClusterTest that captures this issue during downsampling in elastic#125156. To fix this we refine the check that determines if a field is dimension, to skip wrapper field. Fixes elastic#125156.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
When downsampling an index that has a mapping with passthrough dimensions the downsampling process identifies the wrapper object as a dimension and it fails when it tried to retrieve the type. We did some prework to establish a shared framework in the internalClusterTest. For now it only includes setting up time series data stream helpers and a limited assertion helper for dimensions and metrics. This allows us to setup an internalClusterTest that captures this issue during downsampling in elastic#125156. To fix this we refine the check that determines if a field is dimension, to skip wrapper field. Fixes elastic#125156.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downsampling an index that has a mapping with passthrough dimensions the downsampling process identifies the wrapper object as a dimension and it fails when it tried to retrieve the type.
We did some prework to establish a shared framework in the
internalClusterTest. For now it only includes setting up time series data stream helpers and a limited assertion helper for dimensions and metrics. This allows us to setup aninternalClusterTestthat captures this issue during downsampling in #125156.To fix this we refine the check that determines if a field is dimension, to skip wrapper field.
Fixes #125156.