Skip to content

Fix testOptimizerExpressionRuleShouldNotVisitExcludedNodes #127755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025
Merged

Fix testOptimizerExpressionRuleShouldNotVisitExcludedNodes #127755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
029a6e2
Fix testOptimizerExpressionRuleShouldNotVisitExcludedNodes
idegtiarenko May 6, 2025
40d8a62
Merge branch 'main' into fix_127754
idegtiarenko May 7, 2025
b45fe5a
Merge branch 'main' into fix_127754
idegtiarenko May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,9 +435,6 @@ tests:
- class: org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT
method: test {p0=search/350_point_in_time/point-in-time with index filter}
issue: https://github.com/elastic/elasticsearch/issues/127741
- class: org.elasticsearch.xpack.esql.optimizer.OptimizerRulesTests
method: testOptimizerExpressionRuleShouldNotVisitExcludedNodes
issue: https://github.com/elastic/elasticsearch/issues/127754
- class: org.elasticsearch.xpack.remotecluster.RemoteClusterSecurityFcActionAuthorizationIT
method: testIndicesPrivilegesAreEnforcedForCcrRestoreSessionActions
issue: https://github.com/elastic/elasticsearch/issues/127782
Expand Down
4 changes: 2 additions & 2 deletions ...plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/OptimizerRulesTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
import static org.elasticsearch.xpack.esql.core.type.DataType.BOOLEAN;
import static org.elasticsearch.xpack.esql.core.util.TestUtils.getFieldAttribute;
import static org.elasticsearch.xpack.esql.core.util.TestUtils.of;
import static org.hamcrest.Matchers.contains;
import static org.hamcrest.Matchers.containsInAnyOrder;

public class OptimizerRulesTests extends ESTestCase {

Expand Down Expand Up @@ -138,6 +138,6 @@ protected Expression rule(Expression e, LogicalOptimizerContext ctx) {
var alias = new Alias(new Source(1, 18, "x=f1+1"), "x", add);

// contains expressions only from EVAL
assertThat(rule.appliedTo, contains(alias, add, attribute, literal));
assertThat(rule.appliedTo, containsInAnyOrder(alias, add, attribute, literal));
Copy link
Contributor Author

@idegtiarenko idegtiarenko May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might appear as alias, add, attribute, literal or attribute, literal, add, alias depending on TransformDirection

}
}