Skip to content

Conversation

@DaveCTurner
Copy link
Contributor

  • Avoid time-based expiry of channel stats or else testHttpClientStats
    will fail if running multiple iterations for more than 5m.

  • Assert all bytes received in testHttpClientStats.

* Avoid time-based expiry of channel stats or else `testHttpClientStats`
  will fail if running multiple iterations for more than 5m.

* Assert all bytes received in `testHttpClientStats`.
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Network Http and internode communication implementations v9.1.0 labels May 6, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label May 6, 2025
@DaveCTurner
Copy link
Contributor Author

Relates ES-11652 but the test changes make sense in today's code too.

Copy link
Contributor

@JeremyDahlgren JeremyDahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 6, 2025
@elasticsearchmachine elasticsearchmachine merged commit 9765251 into elastic:main May 6, 2025
17 checks passed
@DaveCTurner DaveCTurner deleted the 2025/05/06/netty-incremental-handling-tests-improvements branch May 6, 2025 20:54
parkertimmins pushed a commit to parkertimmins/elasticsearch that referenced this pull request May 7, 2025
* Avoid time-based expiry of channel stats or else `testHttpClientStats`
  will fail if running multiple iterations for more than 5m.

* Assert all bytes received in `testHttpClientStats`.
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request May 9, 2025
* Avoid time-based expiry of channel stats or else `testHttpClientStats`
  will fail if running multiple iterations for more than 5m.

* Assert all bytes received in `testHttpClientStats`.
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request May 9, 2025
* Avoid time-based expiry of channel stats or else `testHttpClientStats`
  will fail if running multiple iterations for more than 5m.

* Assert all bytes received in `testHttpClientStats`.
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request May 12, 2025
* Avoid time-based expiry of channel stats or else `testHttpClientStats`
  will fail if running multiple iterations for more than 5m.

* Assert all bytes received in `testHttpClientStats`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Network Http and internode communication implementations Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants