Change Debug Elasticsearch and debug-jvm order in TESTING.asciidoc
#127801
Conversation
elasticsearchmachine
added
needs:triage
PeteGillinElastic
left a comment
PeteGillinElastic
left a comment
There was a problem hiding this comment.
Hi, thanks for taking the time to improve ES documentation!
I agree that the order required is as you say, so the docs should be changed.
I have one small suggestion.
|
|
||
| --------------------------------------------------------------------------- | ||
| ./gradlew run --debug-jvm | ||
| --------------------------------------------------------------------------- |
There was a problem hiding this comment.
I think that this should probably be moved below the following NOTE: paragraph. That note is about configuring IntelliJ, and it seems better to keep those bits together.
There was a problem hiding this comment.
Thanks for your review @PeteGillinElastic , I think I addressed your suggestion.
There was a problem hiding this comment.
It does address it, yes. Thanks.
PeteGillinElastic
added
>docs
|
Pinging @elastic/es-docs (Team:Docs) |
PeteGillinElastic
left a comment
PeteGillinElastic
left a comment
There was a problem hiding this comment.
Thank you again for taking the time to do this. I can take care of getting this merged.
|
|
||
| --------------------------------------------------------------------------- | ||
| ./gradlew run --debug-jvm | ||
| --------------------------------------------------------------------------- |
There was a problem hiding this comment.
It does address it, yes. Thanks.
|
buildkite test this |
3 participants
When I run
./gradlew run --debug-jvmbeforeDebug Elasticsearch, debug jvm will fail withprocess was found dead while waiting for ports files, node{::runTask-0}. And logs output:Change the order worked.