Make ILM BranchingStep predicate project-aware
#127804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change only makes the predicate inside `BranchingStep` project-aware, to limit the scope of PRs. A follow-up PR will target `ClusterStateActionStep` and all its descendants (including `BranchingStep`).
nielsbauman
added
>non-issue
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
PeteGillinElastic
approved these changes
May 9, 2025
| return clusterState; | ||
| } | ||
| predicateValue.set(predicate.test(index, clusterState)); | ||
| predicateValue.set(predicate.test(index, clusterState.metadata().getProject())); |
Member
There was a problem hiding this comment.
I assume that replacing the call to Metadata.getProject() will be part of the later PR you mentioned which does the level up?
Contributor
Author
There was a problem hiding this comment.
Yep, that's exactly right. I didn't add a @FixForMultiProject because the use of the deprecated getProject() method is automatically "tracked" anyway.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
This change only makes the predicate inside `BranchingStep` project-aware, to limit the scope of PRs. A follow-up PR will target `ClusterStateActionStep` and all its descendants (including `BranchingStep`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only makes the predicate inside
BranchingStepproject-aware, to limit the scope of PRs.A follow-up PR will target
ClusterStateActionStepand all its descendants (includingBranchingStep).