Initialization class as argument to EntitlementAgent #127815
Conversation
ldematte
added
>refactoring
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
| final Class<?> initClazz; | ||
| try { | ||
| initClazz = Class.forName("org.elasticsearch.entitlement.initialization.EntitlementInitialization"); | ||
| initClazz = Class.forName(agentArgs); |
There was a problem hiding this comment.
Making the arguments just be the name of the class, rather than some kind of option flags, doesn't allow much evolution in the future, but then, we are in control of all of this code and change it in the future if need be, just like we did this time, so it doesn't actually matter much.
There was a problem hiding this comment.
I had exactly the same conversation in my head :D wondering if I should do that, and thinking we can change this any time anyway, so I decided to let it like this for now. Unless you or someone else feels strongly about this.
| } | ||
|
|
||
| private static String findAgentJar() { | ||
| public static String findAgentJar() { |
There was a problem hiding this comment.
I'm not sure why this became public, but I presume that will become clear in an upcoming PR.
There was a problem hiding this comment.
This can be package private, right? The TestEntitlementBootstrap can be in the same entitlement bootstrap package (split packages are ok when using the classpath)
There was a problem hiding this comment.
Yes sorry this change slipped in (see the linked PR).
If split packages are OK for tests (as we use the classpath) I will change them the package of TestEntitlementBootstrap etc. and make this (and other method/classes) package-private then.
Preliminary step for test entitlement initialization, extracted from elastic#127814
Preliminary step for test entitlement initialization, extracted from elastic#127814
Preliminary step for test entitlement initialization, extracted from elastic#127814
Preliminary step for test entitlement initialization, extracted from elastic#127814
Preliminary step for test entitlement initialization, extracted from elastic#127814
4 participants
Preliminary step for test entitlement initialization, extracted from #127814