Skip to content

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented May 7, 2025

Continuing the cleanup of SecurityManager related code, this commit removes uses of doPrivileged in all Elasticsearch modules.

Continuing the cleanup of SecurityManager related code, this commit
removes uses of doPrivileged in all Elasticsearch modules.
@rjernst rjernst requested a review from a team as a code owner May 7, 2025 17:13
@rjernst rjernst added >refactoring auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels May 7, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label May 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst rjernst removed the Team:Core/Infra Meta label for core/infra team label May 7, 2025
@rjernst rjernst requested a review from a team May 7, 2025 17:14
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label May 7, 2025
@rjernst
Copy link
Member Author

rjernst commented May 7, 2025

A large portion of this was removed from the repository modules, so asking distrib for review.

@rjernst
Copy link
Member Author

rjernst commented May 7, 2025

Note that the line count of the PR looks bigger than it actually is: most of it is just indentation change from extracting a lambda out.

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst enabled auto-merge (squash) May 9, 2025 00:14
@rjernst
Copy link
Member Author

rjernst commented May 9, 2025

@elasticmachine update branch

@rjernst rjernst merged commit 8ad2723 into elastic:main May 9, 2025
16 of 17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 127848

jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request May 12, 2025
Continuing the cleanup of SecurityManager related code, this commit
removes uses of doPrivileged in all Elasticsearch modules.
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Jun 5, 2025
Continuing the cleanup of SecurityManager related code, this commit
removes uses of doPrivileged in all Elasticsearch modules.
elasticsearchmachine pushed a commit that referenced this pull request Jun 5, 2025
* Remove doPrivileged from ES modules (#127848)

Continuing the cleanup of SecurityManager related code, this commit
removes uses of doPrivileged in all Elasticsearch modules.

* [CI] Auto commit changes from spotless

* fix checkstyle

---------

Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >refactoring Team:Core/Infra Meta label for core/infra team v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants