[ML] Exposing the original request to the error response handler logic #127859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
| return fromResponse(response, ""); | ||
| } | ||
|
|
||
| public static ErrorResponse fromResponse(Request request, HttpResult response) { |
There was a problem hiding this comment.
I'm a bit unclear why we drop the request here? Is this where we would make a follow-up change to utilize the request?
| super(errorMessage); | ||
| } | ||
|
|
||
| public static ErrorResponse fromResponse(Request request, HttpResult response) { |
There was a problem hiding this comment.
Could we add this to the ErrorResponse class to avoid duplication?
| protected final String requestType; | ||
| private final ResponseParser parseFunction; | ||
| private final Function<HttpResult, ErrorResponse> errorParseFunction; | ||
| private final BiFunction<Request, HttpResult, ErrorResponse> errorParseFunction; |
There was a problem hiding this comment.
Just to understand the context better, why do we need the inference ID as part of the error in the custom service PR? Is there a reason we need the full Request here instead of passing just the inference ID?
There was a problem hiding this comment.
Yeah I can just pass the inference id to limit the scope 👍
|
Dan and I chatted and turns out we don't need these changes 🙌 so closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the original request available to the error handling logic so that we can access the inference id. This will be used in the custom service PR by the generic error handler in a failure log message. The request isn't currently used in these changes, I'm just changing the required interfaces.