Skip to content

Conversation

@ywangd
Copy link
Member

@ywangd ywangd commented May 8, 2025

Instead of NPE, this PR throws an AssertionError with more explicit error message.

Relates: #127213

Instead of NPE, this PR throws an AssertionError with more explicit
error message.

Relates: elastic#127213
@ywangd ywangd added >test Issues or PRs that are addressing/adding tests v9.1.0 :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. labels May 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label May 8, 2025
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd
Copy link
Member Author

ywangd commented May 9, 2025

@elasticmachine update branch

@ywangd ywangd added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 9, 2025
@elasticsearchmachine elasticsearchmachine merged commit ca18a86 into elastic:main May 9, 2025
17 checks passed
@ywangd ywangd deleted the trivial-npe-handling-for-get-master-name branch May 9, 2025 03:47
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request May 12, 2025
Instead of NPE, this PR throws an AssertionError with more explicit
error message.

Relates: elastic#127213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Distributed A catch all label for anything in the Distributed Coordination area. Please avoid if you can. Team:Distributed Coordination Meta label for Distributed Coordination team >test Issues or PRs that are addressing/adding tests v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants